Skip to content

Fixed issue where updated variables weren't getting picked up - #180

Closed
maneesht wants to merge 9 commits into
invertase:mainfrom
maneesht:mtewani/fix-variables-update
Closed

Fixed issue where updated variables weren't getting picked up#180
maneesht wants to merge 9 commits into
invertase:mainfrom
maneesht:mtewani/fix-variables-update

Conversation

@maneesht

Copy link
Copy Markdown
Contributor

No description provided.

@docs-page

docs-page Bot commented Mar 28, 2025

Copy link
Copy Markdown

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/tanstack-query-firebase~180

Documentation is deployed and generated using docs.page.

Comment thread packages/react/package.json Outdated
@geriux

geriux commented Jun 23, 2025

Copy link
Copy Markdown

I'm trying out this library and I'm having this issue where updated variables aren't getting picked up for newer fetches, is there more work pending on this PR? Thanks!

@maneesht

Copy link
Copy Markdown
Contributor Author

Hi @geriux, thank you for reaching out, we'll prioritize getting this in ASAP.

@geriux

geriux commented Jun 23, 2025

Copy link
Copy Markdown

Hi @geriux, thank you for reaching out, we'll prioritize getting this in ASAP.

Thank you so much! I quickly tested these changes and they fixed my problem, thanks for prioritizing it! 🙌

@cabljac

cabljac commented Jun 24, 2025

Copy link
Copy Markdown
Collaborator

Hi, i'm going to get this merged and released this week. Apparently there are some conflicts, i'll look to resolve these ASAP.

Comment thread packages/react/src/data-connect/utils.test.ts Outdated
@mickeywu

Copy link
Copy Markdown

Hello, I'm also facing this issue and noticed that the code fix (32f06b8) was actually merged in yesterday with the package version bumped to 2.0.1. However, the new version doesn't seem to have been released to NPM. Wondering if the release will be happening soon?

Thank you for all the hard work on this package, it makes using Firebase Data Connect a breeze with React! 🙏

@HassanBahati

Copy link
Copy Markdown
Contributor

Hi @mickeywu, exciting to know that this package makes it a breeze for you to use Firebase Data Connect with React. Sure yes 32f06b8 was merged which should contain all fixes in there. We are working on getting the release published very soon and will be sure to update you. Cheers!

@cabljac

cabljac commented Jun 30, 2025

Copy link
Copy Markdown
Collaborator

Hi all, thanks for your patience. I've just published a new version. In the near future we will set up automated releases which will make the whole process smoother.

Closing this PR now, as the other one superseded it.

@cabljac cabljac closed this Jun 30, 2025
@github-project-automation github-project-automation Bot moved this from Approved [PR] to Done in [Cloud] Open Source P0 Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants